Fix for psql \d tab completion

Started by Bruce Momjianabout 17 years ago3 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Robert Treat reported to me that \dS tab completion was not working in
CVS HEAD. I have adjusted the code to handle this and be more flexible
about \d modifiers.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload+53-60
#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Bruce Momjian (#1)
Re: Fix for psql \d tab completion

Bruce Momjian wrote:

Robert Treat reported to me that \dS tab completion was not working in
CVS HEAD. I have adjusted the code to handle this and be more flexible
about \d modifiers.

Doesn't this break completion for stuff like \daS, etc?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#2)
Re: Fix for psql \d tab completion

Alvaro Herrera <alvherre@commandprompt.com> writes:

Bruce Momjian wrote:

Robert Treat reported to me that \dS tab completion was not working in
CVS HEAD. I have adjusted the code to handle this and be more flexible
about \d modifiers.

Doesn't this break completion for stuff like \daS, etc?

AFAICS \daS still works (that's why it's strncmp not just strcmp).

The thing that still doesn't work particularly well is completion
on the \dtisv family; this coding will only complete for the type
of object denoted by the first letter after \d. It's not clear how
important that is in the real world, though; and it wasn't any better
before.

regards, tom lane