pgsql: Detect unused steps in isolation specs and do some cleanup

Started by Michael Paquierabout 5 years ago1 messagescomitters

michael@paquier.xyz

about 5 years ago

Detect unused steps in isolation specs and do some cleanup

This is useful for developers to find out if an isolation spec is
over-engineered or if it needs more work by warning at the end of a
test run if a step is not used, generating a failure with extra diffs.

While on it, clean up all the specs which include steps not used in any
permutations to simplify them.

This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to
make all the branches consistent for an upcoming patch that will improve
the output generated by isolationtester.

Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: /messages/by-id/20190819080820.GG18166@paquier.xyz
Discussion: /messages/by-id/794820.1623872009@sss.pgh.pa.us
Backpatch-through: 9.6

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8f32299424d90b0dab792bf96a5b0e3a62cc63da

Modified Files
--------------
.../test_decoding/specs/concurrent_ddl_dml.spec | 9 -----
contrib/test_decoding/specs/snapshot_transfer.spec | 1 -
.../isolation/expected/eval-plan-qual-trigger.out | 2 +-
src/test/isolation/isolationtester.c | 19 ++++++++++-
src/test/isolation/isolationtester.h | 1 +
src/test/isolation/specparse.y | 1 +
.../isolation/specs/eval-plan-qual-trigger.spec | 38 +++++++++++-----------
src/test/isolation/specs/freeze-the-dead.spec | 3 --
.../specs/insert-conflict-do-nothing.spec | 1 -
.../specs/insert-conflict-do-update-2.spec | 1 -
.../isolation/specs/insert-conflict-do-update.spec | 1 -
.../isolation/specs/partition-key-update-1.spec | 1 -
src/test/isolation/specs/sequence-ddl.spec | 1 -
.../specs/tuplelock-upgrade-no-deadlock.spec | 3 --
14 files changed, 40 insertions(+), 42 deletions(-)