pgsql: process startup: Centralize pgwin32_signal_initialize() calls.
process startup: Centralize pgwin32_signal_initialize() calls.
For one, the existing location lead to somewhat awkward code in main(). For
another, the new location is easier to understand anyway.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Discussion: /messages/by-id/20210802164124.ufo5buo4apl6yuvs@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/07bf37850991c68a7038fb06186bddfd64c72faf
Modified Files
--------------
src/backend/main/main.c | 29 +++++++++--------------------
src/backend/postmaster/postmaster.c | 9 ---------
src/backend/utils/init/miscinit.c | 19 ++++++++++++++++++-
3 files changed, 27 insertions(+), 30 deletions(-)
Hi,
On 2021-08-05 19:36:30 +0000, Andres Freund wrote:
process startup: Centralize pgwin32_signal_initialize() calls.
For one, the existing location lead to somewhat awkward code in main(). For
another, the new location is easier to understand anyway.Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Discussion: /messages/by-id/20210802164124.ufo5buo4apl6yuvs@alap3.anarazel.de
Looking at the windows failures...
Greetings,
Andres Freund
Hi,
On 2021-08-05 14:41:09 -0700, Andres Freund wrote:
On 2021-08-05 19:36:30 +0000, Andres Freund wrote:
process startup: Centralize pgwin32_signal_initialize() calls.
For one, the existing location lead to somewhat awkward code in main(). For
another, the new location is easier to understand anyway.Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Discussion: /messages/by-id/20210802164124.ufo5buo4apl6yuvs@alap3.anarazel.deLooking at the windows failures...
A bit embarassing: /messages/by-id/E1mBlyy-00015X-Rt@gemulon.postgresql.org
Once I went through the effort of getting my windows vm + msvc build running
again it was fairly obvious...
Perhaps we should get windows postgres work on wine, I don't think it'd take
that much.