pgsql: Fix failure of btree_gin indexscans with "char" type and </<= op

Started by Tom Lanealmost 5 years ago1 messagescomitters

tgl@sss.pgh.pa.us

almost 5 years ago

Fix failure of btree_gin indexscans with "char" type and </<= operators.

As a result of confusion about whether the "char" type is signed or
unsigned, scans for index searches like "col < 'x'" or "col <= 'x'"
would start at the middle of the index not the left end, thus missing
many or all of the entries they should find. Fortunately, this
is not a symptom of index corruption. It's only the search logic
that is broken, and we can fix it without unpleasant side-effects.

Per report from Jason Kim. This has been wrong since btree_gin's
beginning, so back-patch to all supported branches.

Discussion: /messages/by-id/20210810001649.htnltbh7c63re42p@jasonk.me

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cd7d9b6b63f1ed1d60cab3888eb0fc2523de6f0e

Modified Files
--------------
contrib/btree_gin/btree_gin.c | 2 +-
contrib/btree_gin/expected/char.out | 11 +++++++++--
2 files changed, 10 insertions(+), 3 deletions(-)