pgsql: Make node output prefix match node structure name

Started by Peter Eisentrautalmost 5 years ago3 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Make node output prefix match node structure name

In most cases, the prefix string in a node output is the upper case of
the node structure name, e.g., MergeAppend -> MERGEAPPEND. There were
a few exceptions that for either no apparent reason or perhaps minor
aesthetic reasons deviated from this. In order to simplify this and
perhaps allow automatic generation without having to deal with
exception cases, make them all match.

Discussion: /messages/by-id/c091e5cd-45f8-69ee-6a9b-de86912cc7e7@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e58136069687b9cf29c27281e227ac397d72141d

Modified Files
--------------
src/backend/nodes/outfuncs.c | 22 +++++++++++-----------
src/backend/nodes/readfuncs.c | 22 +++++++++++-----------
2 files changed, 22 insertions(+), 22 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: pgsql: Make node output prefix match node structure name

Peter Eisentraut <peter@eisentraut.org> writes:

Make node output prefix match node structure name

Just for the record, this should have included a catversion bump,
since it surely broke stored rules.

regards, tom lane

#3Vik Fearing
vik@postgresfriends.org
In reply to: Tom Lane (#2)
Re: pgsql: Make node output prefix match node structure name

On 9/15/21 5:30 PM, Tom Lane wrote:

Peter Eisentraut <peter@eisentraut.org> writes:

Make node output prefix match node structure name

Just for the record, this should have included a catversion bump,
since it surely broke stored rules.

It did. I just ran into a problem cause by the lack of catversion bump.
I am hoping something gets committed soon that contains one.
--
Vik Fearing