pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

Started by Michael Paquierover 4 years ago1 messagescomitters
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Correct comment and some documentation about REPLICA_IDENTITY_INDEX

catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a
dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells
a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING.

The behavior exists since the introduction of replica identities, and
fe7fd4e even added tests for this case but I somewhat forgot to fix this
comment.

While on it, this commit reorganizes the documentation about replica
identities on the ALTER TABLE page, and a note is added about the case
of dropped indexes with REPLICA_IDENTITY_INDEX.

Author: Michael Paquier, Wei Wang
Reviewed-by: Euler Taveira
Discussion: /messages/by-id/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com
Backpatch-through: 10

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1a0ef5e2cc63797feec1bbbf2ca89906fed76bfb

Modified Files
--------------
doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------
src/include/catalog/pg_class.h | 2 +-
2 files changed, 44 insertions(+), 9 deletions(-)