pgxs and make check message

Started by Peter Eisentrautalmost 17 years ago2 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Isn't it a bad idea that this from pgxs.mk does not return a non-zero status?

check:
@echo "'make check' is not supported."
@echo "Do 'make install', then 'make installcheck' instead."

Or is something relying on a nonexisting test suite passing successfully?

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Peter Eisentraut (#1)
Re: pgxs and make check message

On Monday 06 July 2009 22:42:54 Peter Eisentraut wrote:

Isn't it a bad idea that this from pgxs.mk does not return a non-zero
status?

check:
@echo "'make check' is not supported."
@echo "Do 'make install', then 'make installcheck' instead."

Or is something relying on a nonexisting test suite passing successfully?

I suppose nothing is, so I have made this change.