pgsql: Ensure that length argument of memcmp() isn't seen as negative.
Ensure that length argument of memcmp() isn't seen as negative.
I think this will shut up a weird warning from buildfarm member
serinus. Perhaps it'd be better to change tsCompareString's
length arguments to unsigned, but that seems more invasive
than is justified.
Part of a general push to remove off-the-beaten-track warnings
where we can easily do so.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3b0ee7f583dc347c4aecb57d35830d2f99956e5c
Modified Files
--------------
src/backend/utils/adt/tsvector_op.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
On 2022-02-15 22:28:23 +0000, Tom Lane wrote:
Ensure that length argument of memcmp() isn't seen as negative.
I think this will shut up a weird warning from buildfarm member
serinus. Perhaps it'd be better to change tsCompareString's
length arguments to unsigned, but that seems more invasive
than is justified.
Just FYI, I'd reported this to gcc some time last year
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100442
and then forgot about it.
They're not wrong there is the possibility of exceeding the bounds, but the
error message still is quite confusing.
Greetings,
Andres Freund