pgsql: Backpatch addition of wait_for_log(), pump_until().

Started by Andres Freundabout 4 years ago3 messagescomitters
Jump to latest
#1Andres Freund
andres@anarazel.de

Backpatch addition of wait_for_log(), pump_until().

These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are
needed by a about-to-be-backpatched test.

Discussion: /messages/by-id/20220413002626.udl7lll7f3o7nre7@alap3.anarazel.de
Backpatch: 10-14

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/90abe1e17f9d3f725cf92a3ef43593ec56eaf671

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Utils.pm | 1 +
src/test/perl/PostgresNode.pm | 35 ++++++++++++++++++++++++++++++++++
src/test/perl/TestLib.pm | 31 ++++++++++++++++++++++++++++++
3 files changed, 67 insertions(+)

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Andres Freund (#1)
Re: pgsql: Backpatch addition of wait_for_log(), pump_until().

On 03.05.22 03:11, Andres Freund wrote:

Backpatch addition of wait_for_log(), pump_until().

These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are
needed by a about-to-be-backpatched test.

I see this warning:

Subroutine pump_until redefined at t/013_crash_restart.pl line 246.

(There are a varying number of these warnings across the backbranches.)

Also, the local definition has different arguments than the backpatched
one. This should be double-checked.

#3Andres Freund
andres@anarazel.de
In reply to: Peter Eisentraut (#2)
Re: pgsql: Backpatch addition of wait_for_log(), pump_until().

Hi,

On 2022-05-06 15:29:43 +0200, Peter Eisentraut wrote:

On 03.05.22 03:11, Andres Freund wrote:

Backpatch addition of wait_for_log(), pump_until().

These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are
needed by a about-to-be-backpatched test.

I see this warning:

Subroutine pump_until redefined at t/013_crash_restart.pl line 246.

Yea :(. See bottom of /messages/by-id/20220506030927.6qehktk6bodv4ft3@alap3.anarazel.de

Also, the local definition has different arguments than the backpatched one.
This should be double-checked.

That's as it's in the "original" commit...

Greetings,

Andres Freund