pgsql: pg_dump: Dump colliculocale
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t229229psql -h localhost -U postgresBuilt from patchset v5 (message #5), July 29, 2026 at 12:54 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t229229_5 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t229229_5 && git checkout t229229_5Patchset v5 (message #5) is on t229229_5
pg_dump: Dump colliculocale
This was forgotten when the new column was introduced.
Author: Marina Polyakova <m.polyakova@postgrespro.ru>
Reviewed-by: Julien Rouhaud <rjuju123@gmail.com>
Discussion: /messages/by-id/7ad26354e75259f59c4a6c6997b8ee32@postgrespro.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/396d348b046c6b7e5dc83158c4c1df1377a1d2ef
Modified Files
--------------
src/bin/pg_dump/Makefile | 1 +
src/bin/pg_dump/pg_dump.c | 50 +++++++++++++++++++++++++++++++++-------
src/bin/pg_dump/t/002_pg_dump.pl | 28 +++++++++++++++++++++-
3 files changed, 70 insertions(+), 9 deletions(-)
Peter Eisentraut <peter@eisentraut.org> writes:
pg_dump: Dump colliculocale
The *BSD buildfarm members don't seem too happy with the new test case.
regards, tom lane
I wrote:
Peter Eisentraut <peter@eisentraut.org> writes:
pg_dump: Dump colliculocale
The *BSD buildfarm members don't seem too happy with the new test case.
Not just those. I found that on my RHEL8 box, the new pg_dump
test passes if the environment has LANG=en_US.utf8, and fails
if LANG=C.
regards, tom lane
Hello!
Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me...
On 2022-08-25 04:46, Tom Lane wrote:
I wrote:
The *BSD buildfarm members don't seem too happy with the new test
case.Not just those. I found that on my RHEL8 box, the new pg_dump
test passes if the environment has LANG=en_US.utf8, and fails
if LANG=C.regards, tom lane
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
diff_fix_002_pg_dump.patchtext/x-diff; name=diff_fix_002_pg_dump.patchDownload+24-8
More precisely, diff_fix_002_pg_dump_v2.patch...
On 2022-08-25 07:50, Marina Polyakova wrote:
Hello!
Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me...
On 2022-08-25 04:46, Tom Lane wrote:
I wrote:
The *BSD buildfarm members don't seem too happy with the new test
case.Not just those. I found that on my RHEL8 box, the new pg_dump
test passes if the environment has LANG=en_US.utf8, and fails
if LANG=C.regards, tom lane
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Thanks, I had already fixed it.
Show quoted text
On 25.08.22 07:03, Marina Polyakova wrote:
More precisely, diff_fix_002_pg_dump_v2.patch...
On 2022-08-25 07:50, Marina Polyakova wrote:
Hello!
Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me...
On 2022-08-25 04:46, Tom Lane wrote:
I wrote:
The *BSD buildfarm members don't seem too happy with the new test case.
Not just those. I found that on my RHEL8 box, the new pg_dump
test passes if the environment has LANG=en_US.utf8, and fails
if LANG=C.regards, tom lane