pgsql: Straighten include order in guc-file.l

Started by John Naylorover 3 years ago3 messagescomitters
Jump to latest
#1John Naylor
john.naylor@enterprisedb.com

Straighten include order in guc-file.l

Oversight in dac048f71eb

Michael Paquier

Reviewed by Julien Rouhaud
Discussion: /messages/by-id/Y2IATvRGo347Lvd1@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/062eef3a9bbd5da9c26c93127ee6272193cb06e6

Modified Files
--------------
src/backend/utils/misc/guc-file.l | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

#2John Naylor
john.naylor@enterprisedb.com
In reply to: John Naylor (#1)
Re: pgsql: Straighten include order in guc-file.l

On Thu, Nov 3, 2022 at 12:39 PM John Naylor <john.naylor@postgresql.org>
wrote:

https://git.postgresql.org/pg/commitdiff/062eef3a9bbd5da9c26c93127ee6272193cb06e6

flaviventris fails on the pg_resetwal test with "initdb: error: invalid
locale settings; check LANG and LC_* environment variables", and
idiacanthus fails to start the server in another tap test. But if this
commit were at fault, surely they would fail more spectacularly?

--
John Naylor
EDB: http://www.enterprisedb.com

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: John Naylor (#2)
Re: pgsql: Straighten include order in guc-file.l

John Naylor <john.naylor@enterprisedb.com> writes:

flaviventris fails on the pg_resetwal test with "initdb: error: invalid
locale settings; check LANG and LC_* environment variables", and
idiacanthus fails to start the server in another tap test. But if this
commit were at fault, surely they would fail more spectacularly?

Given the shortage of other failures, I'd write these off as noise
... unless they reproduce in future runs. But even then, it's
very hard to blame it on this commit.

regards, tom lane