pgsql: meson: Add 'running' test setup, as a replacement for installche

Started by Andres Freundover 3 years ago3 messagescomitters
Jump to latest
#1Andres Freund
andres@anarazel.de

meson: Add 'running' test setup, as a replacement for installcheck

To run all tests that support running against existing server:
$ meson test --setup running

To run just the main pg_regress tests against existing server:
$ meson test --setup running regress-running/regress

To ensure the 'running' setup continues to work, test it as part of the
freebsd CI task.

Discussion: /messages/by-id/CAH2-Wz=XDQcmLoo7RR_i6FKQdDmcyb9q5gStnfuuQXrOGhB2sQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f0e786ccbf50a2f819fbf72d51ba13221adaaa1

Modified Files
--------------
.cirrus.yml | 15 +++++
contrib/basic_archive/meson.build | 3 +
contrib/pg_freespacemap/meson.build | 3 +
contrib/pg_stat_statements/meson.build | 4 ++
contrib/pg_walinspect/meson.build | 3 +
contrib/test_decoding/meson.build | 5 ++
doc/src/sgml/installation.sgml | 6 ++
meson.build | 91 ++++++++++++++++++++++-----
src/interfaces/ecpg/test/meson.build | 1 +
src/test/isolation/meson.build | 1 +
src/test/modules/commit_ts/meson.build | 3 +
src/test/modules/snapshot_too_old/meson.build | 3 +
src/test/modules/test_oat_hooks/meson.build | 1 +
src/test/modules/test_pg_dump/meson.build | 2 +
src/test/modules/test_slru/meson.build | 1 +
src/test/modules/worker_spi/meson.build | 4 +-
src/test/regress/meson.build | 1 +
17 files changed, 132 insertions(+), 15 deletions(-)

#2Thomas Munro
thomas.munro@gmail.com
In reply to: Andres Freund (#1)
Re: pgsql: meson: Add 'running' test setup, as a replacement for installche

On Thu, Dec 8, 2022 at 9:48 AM Andres Freund <andres@anarazel.de> wrote:

meson: Add 'running' test setup, as a replacement for installcheck

The -running tests don't seem to be completely stable on CI. I don't
know why (smells like plan changes?) but see cfbot.cputube.org for
some flapping on FreeBSD (the only OS where this is enabled), and
there's also one example on github.com/posgres/postgres that seems a
bit different.

Show quoted text

To run all tests that support running against existing server:
$ meson test --setup running

To run just the main pg_regress tests against existing server:
$ meson test --setup running regress-running/regress

To ensure the 'running' setup continues to work, test it as part of the
freebsd CI task.

Discussion: /messages/by-id/CAH2-Wz=XDQcmLoo7RR_i6FKQdDmcyb9q5gStnfuuQXrOGhB2sQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f0e786ccbf50a2f819fbf72d51ba13221adaaa1

Modified Files
--------------
.cirrus.yml | 15 +++++
contrib/basic_archive/meson.build | 3 +
contrib/pg_freespacemap/meson.build | 3 +
contrib/pg_stat_statements/meson.build | 4 ++
contrib/pg_walinspect/meson.build | 3 +
contrib/test_decoding/meson.build | 5 ++
doc/src/sgml/installation.sgml | 6 ++
meson.build | 91 ++++++++++++++++++++++-----
src/interfaces/ecpg/test/meson.build | 1 +
src/test/isolation/meson.build | 1 +
src/test/modules/commit_ts/meson.build | 3 +
src/test/modules/snapshot_too_old/meson.build | 3 +
src/test/modules/test_oat_hooks/meson.build | 1 +
src/test/modules/test_pg_dump/meson.build | 2 +
src/test/modules/test_slru/meson.build | 1 +
src/test/modules/worker_spi/meson.build | 4 +-
src/test/regress/meson.build | 1 +
17 files changed, 132 insertions(+), 15 deletions(-)

#3Andres Freund
andres@anarazel.de
In reply to: Thomas Munro (#2)
Re: pgsql: meson: Add 'running' test setup, as a replacement for installche

Hi,

On 2022-12-16 19:52:41 +1300, Thomas Munro wrote:

On Thu, Dec 8, 2022 at 9:48 AM Andres Freund <andres@anarazel.de> wrote:

meson: Add 'running' test setup, as a replacement for installcheck

The -running tests don't seem to be completely stable on CI. I don't
know why (smells like plan changes?) but see cfbot.cputube.org for
some flapping on FreeBSD (the only OS where this is enabled), and
there's also one example on github.com/posgres/postgres that seems a
bit different.

Yep, see
/messages/by-id/20221209001511.n3vqodxobqgscuil@awork3.anarazel.de
and then the prototype patch at
/messages/by-id/20221209020815.wsoixct72c6hst5l@awork3.anarazel.de

without that patch the tests failed locally within < 10 iterations, with
it I got through 100 without a failure.

Greetings,

Andres Freund