remove useless set of active snap
This patch removes a useless pushing of an active snapshot on
PortalStart. Instead of push/get/pop of the active snapshot, without
any intervening use of the active snapshot, we just pass a local
snapshot down to CreateQueryDesc.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
Attachments:
useless-activesnap.patchtext/x-diff; charset=us-asciiDownload+9-9
Alvaro Herrera wrote:
This patch removes a useless pushing of an active snapshot on
PortalStart. Instead of push/get/pop of the active snapshot, without
any intervening use of the active snapshot, we just pass a local
snapshot down to CreateQueryDesc.
Alvaro, what happened to this patch?
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +
Bruce Momjian wrote:
Alvaro Herrera wrote:
This patch removes a useless pushing of an active snapshot on
PortalStart. Instead of push/get/pop of the active snapshot, without
any intervening use of the active snapshot, we just pass a local
snapshot down to CreateQueryDesc.Alvaro, what happened to this patch?
I dropped it because pushing the active snap is no so much a no-op
anymore (it creates a new copy), so the semantics could change.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support