pgsql: Remove special outfuncs/readfuncs handling of RangeVar.catalogna

Started by Tom Laneover 3 years ago2 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Remove special outfuncs/readfuncs handling of RangeVar.catalogname.

Historically we skipped writing/reading this field, but that no
longer works under WRITE_READ_PARSE_PLAN_TREES since we expanded
the coverage of that option to include utility commands (787102b56).
Remove the special case and just treat this field normally.

Bump catversion out of an abundance of caution --- I do not think
we currently ever store RangeVar nodes in the catalogs, but
perhaps I'm wrong.

Per report from Pavel Stehule.

Discussion: /messages/by-id/CAFj8pRAYvYu-qU7-NieqRRyaQZk-yr3UjtHQ2LR62PS9M1dZMA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3cece34be842178a3c5697a58e03fb4a5d576378

Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/nodes/primnodes.h | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)

#2Pavel Stehule
pavel.stehule@gmail.com
In reply to: Tom Lane (#1)
Re: pgsql: Remove special outfuncs/readfuncs handling of RangeVar.catalogna

po 23. 1. 2023 v 19:33 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:

Remove special outfuncs/readfuncs handling of RangeVar.catalogname.

Historically we skipped writing/reading this field, but that no
longer works under WRITE_READ_PARSE_PLAN_TREES since we expanded
the coverage of that option to include utility commands (787102b56).
Remove the special case and just treat this field normally.

Bump catversion out of an abundance of caution --- I do not think
we currently ever store RangeVar nodes in the catalogs, but
perhaps I'm wrong.

Per report from Pavel Stehule.

It helps

Thank you

Pavel

Show quoted text

Discussion:
/messages/by-id/CAFj8pRAYvYu-qU7-NieqRRyaQZk-yr3UjtHQ2LR62PS9M1dZMA@mail.gmail.com

Branch
------
master

Details
-------

https://git.postgresql.org/pg/commitdiff/3cece34be842178a3c5697a58e03fb4a5d576378

Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/nodes/primnodes.h | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)