Where's the docs?

Started by Josh Berkusover 16 years ago7 messageshackers
Jump to latest
#1Josh Berkus
josh@agliodbs.com

Folks,

I'm looking at the "developer docs" on our site, and I couldn't find any
docs for the following features:

Column Triggers
Calling Named Function parameters
DEFAULT privileges

... without docs, we really can't expect people to test them. Do we
have partial docs for these? Am I not looking in the right place?

--Josh Berkus

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Josh Berkus (#1)
Re: Where's the docs?

Josh Berkus <josh@agliodbs.com> writes:

I'm looking at the "developer docs" on our site, and I couldn't find any
docs for the following features:

Column Triggers

http://developer.postgresql.org/pgdocs/postgres/sql-createtrigger.html

Calling Named Function parameters

http://developer.postgresql.org/pgdocs/postgres/sql-syntax-calling-funcs.html

DEFAULT privileges

http://developer.postgresql.org/pgdocs/postgres/sql-alterdefaultprivileges.html

regards, tom lane

#3Josh Berkus
josh@agliodbs.com
In reply to: Tom Lane (#2)
Re: Where's the docs?

Tom,

I'm looking at the "developer docs" on our site, and I couldn't find any
docs for the following features:

Column Triggers

http://developer.postgresql.org/pgdocs/postgres/sql-cre

atetrigger.html

OK, this is the genuine failure; the syntax is missing for column triggers:

CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
EXECUTE PROCEDURE function_name ( arguments )

Does a doc patch already exist for this, or do I need to write one?

Calling Named Function parameters

http://developer.postgresql.org/pgdocs/postgres/sql-syntax-calling-funcs.html

DEFAULT privileges

http://developer.postgresql.org/pgdocs/postgres/sql-alterdefaultprivileges.html

Thanks for these, I wasn't finding them. Problem of no search on the
developer docs ...

--Josh Berkus

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Josh Berkus (#3)
Re: Where's the docs?

Josh Berkus <josh@agliodbs.com> writes:

OK, this is the genuine failure; the syntax is missing for column triggers:

CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
EXECUTE PROCEDURE function_name ( arguments )

It's embedded in "event", which isn't spelled out here.

regards, tom lane

#5Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#4)
Re: Where's the docs?

On Wed, 2009-10-28 at 00:25 -0400, Tom Lane wrote:

Josh Berkus <josh@agliodbs.com> writes:

OK, this is the genuine failure; the syntax is missing for column triggers:

CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
EXECUTE PROCEDURE function_name ( arguments )

It's embedded in "event", which isn't spelled out here.

I know this is a bit suboptimal, but I couldn't think of a better way
without cluttering up to many things.

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#5)
Re: Where's the docs?

Peter Eisentraut <peter_e@gmx.net> writes:

On Wed, 2009-10-28 at 00:25 -0400, Tom Lane wrote:

Josh Berkus <josh@agliodbs.com> writes:

OK, this is the genuine failure; the syntax is missing for column triggers:

CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
EXECUTE PROCEDURE function_name ( arguments )

It's embedded in "event", which isn't spelled out here.

I know this is a bit suboptimal, but I couldn't think of a better way
without cluttering up to many things.

Expanding "event" in-place definitely wouldn't be very readable. The
only alternative that seems sane is to do something like what we do
in SELECT:

CREATE TRIGGER ...

where "event" is:

INSERT | UPDATE [ ( column [,...] ) ] | DELETE | TRUNCATE

I am not convinced that it's worth it, but maybe. Certainly the current
psql "\h CREATE TRIGGER" display is not helpful at reminding you where
to put the column names.

regards, tom lane

#7Josh Berkus
josh@agliodbs.com
In reply to: Tom Lane (#4)
Re: Where's the docs?

On 10/27/09 9:25 PM, Tom Lane wrote:

Josh Berkus <josh@agliodbs.com> writes:

OK, this is the genuine failure; the syntax is missing for column triggers:

CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
EXECUTE PROCEDURE function_name ( arguments )

It's embedded in "event", which isn't spelled out here.

Yeah, I couldn't figure it out from the docs, which means that other
people won't be able to. Doc patch coming if I ever finish this server
migration.

--Josh Berkus