pgsql: Avoid using atooid for numerical comparisons which arent Oids

Started by Daniel Gustafssonover 3 years ago1 messagescomitters

daniel@yesql.se

over 3 years ago

Avoid using atooid for numerical comparisons which arent Oids

The check for the number of roles in the target cluster for an upgrade
selects the existing roles and performs a COUNT(*) over the result. A
value of one is the expected query result value indicating that only
the install user is present in the new cluster. The result was converted
with the function for converting a string containing an Oid into a numeric,
which avoids potential overflow but makes the code less readable since
it's not actually an Oid at all.

Discussion: /messages/by-id/41AB5F1F-4389-4B25-9668-5C430375836C@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/106f26a849bbb760a270e9a3c586aeb73899e26a

Modified Files
--------------
src/bin/pg_upgrade/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)