pgsql: Pass constructName to transformJsonValueExpr()

Started by Amit Langotealmost 3 years ago3 messagescomitters
Jump to latest
#1Amit Langote
Langote_Amit_f8@lab.ntt.co.jp

Pass constructName to transformJsonValueExpr()

This allows it to pass to coerce_to_specific_type() the actual name
corresponding to the specific JSON_* function expression being
transformed, instead of the currently hardcoded string.

Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: /messages/by-id/CA+HiwqE4XTdfb1nW=Ojoy_tQSRhYt-q_kb6i5d4xcKyrLC1Nbg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/785480c9533d9a905410c1a52f857a431daec37c

Modified Files
--------------
src/backend/parser/parse_expr.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Amit Langote (#1)
Re: pgsql: Pass constructName to transformJsonValueExpr()

Amit Langote <amitlan@postgresql.org> writes:

Pass constructName to transformJsonValueExpr()

Surely "char *constructName" should be "const char *constructName"?

regards, tom lane

#3Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Tom Lane (#2)
Re: pgsql: Pass constructName to transformJsonValueExpr()

On Thu, Jul 13, 2023 at 1:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

Amit Langote <amitlan@postgresql.org> writes:

Pass constructName to transformJsonValueExpr()

Surely "char *constructName" should be "const char *constructName"?

Right you are. Fixed.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com