pgsql: Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

Started by Michael Paquieralmost 3 years ago1 messagescomitters

michael@paquier.xyz

almost 3 years ago

Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

Based on how postgres.h foes the Oid <-> Datum conversion, there is no
existing bugs but let's be consistent. 17 spots have been noticed as
incorrectly passing down Oids rather than Datums. Aleksander got one,
Zhang two and I the rest.

Author: Michael Paquier, Aleksander Alekseev, Zhang Mingli
Discussion: /messages/by-id/ZLUhqsqQN1MOaxdw@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a990abd79acea4717cc8f982a28f35b6b347ddb

Modified Files
--------------
src/backend/catalog/index.c | 2 +-
src/backend/commands/alter.c | 3 ++-
src/backend/commands/sequence.c | 4 ++--
src/backend/commands/tablecmds.c | 9 +++++----
src/backend/commands/user.c | 2 +-
src/backend/partitioning/partbounds.c | 2 +-
src/backend/partitioning/partdesc.c | 2 +-
src/backend/utils/adt/acl.c | 4 ++--
src/backend/utils/adt/ruleutils.c | 2 +-
src/backend/utils/cache/lsyscache.c | 6 ++++--
src/backend/utils/cache/partcache.c | 3 ++-
11 files changed, 22 insertions(+), 17 deletions(-)