pgsql: Fix last remaining uninitialized memory warnings

Started by Peter Eisentrautalmost 3 years ago2 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Fix last remaining uninitialized memory warnings

gcc (version 13) fails to properly analyze the code due to the loop
stop condition including `l != NULL`. Let's just help it out.

Author: Tristan Partin <tristan@neon.tech>
Discussion: /messages/by-id/CT6HJ3U8068R.3A8SJMV02D9BC@gonk

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4a8fef0d733965c1a1836022f8a42ab1e83a721f

Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
src/bin/pgbench/pgbench.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

#2Peter Smith
smithpb2250@gmail.com
In reply to: Peter Eisentraut (#1)
Re: pgsql: Fix last remaining uninitialized memory warnings

FYI - When building the latest HEAD I noticed some compiler warnings
that seem related to this change

pgbench.c: In function ‘evalStandardFunc’:
pgbench.c:2242:2: warning: missing braces around initializer [-Wmissing-braces]
PgBenchValue vargs[MAX_FARGS] = { 0 };
^
pgbench.c:2242:2: warning: (near initialization for ‘vargs[0]’)
[-Wmissing-braces]

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Show quoted text

On Wed, Aug 9, 2023 at 6:05 PM Peter Eisentraut <peter@eisentraut.org> wrote:

Fix last remaining uninitialized memory warnings

gcc (version 13) fails to properly analyze the code due to the loop
stop condition including `l != NULL`. Let's just help it out.

Author: Tristan Partin <tristan@neon.tech>
Discussion: /messages/by-id/CT6HJ3U8068R.3A8SJMV02D9BC@gonk

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4a8fef0d733965c1a1836022f8a42ab1e83a721f

Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
src/bin/pgbench/pgbench.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)