pgsql: Remove code that attempted to rename index columns to keep them

Tom Lane wrote:

Log Message:
-----------
Remove code that attempted to rename index columns to keep them in sync with
their underlying table columns. That code was not bright enough to cope with
collision situations (ie, new name conflicts with some other column of the
index). Since there is no functional reason to do this at all, trying to
upgrade the logic to be bulletproof doesn't seem worth the trouble.

This change means that both the index name and the column names of an index
are set when it's created, and won't be automatically changed when the
underlying table columns are renamed. Neatnik DBAs are still free to rename
them manually, of course.

Does this mean this TODO items should be modified to remove the index
name mention?

Add ALTER TABLE RENAME CONSTRAINT, update index name also

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian <bruce@momjian.us> writes:

Does this mean this TODO items should be modified to remove the index
name mention?

Add ALTER TABLE RENAME CONSTRAINT, update index name also

No, that has nothing to do with this.

We already have ALTER INDEX renaming the associated constraint, so
I'm not sure how important the TODO item really is. But if someone
were to do it, we'd certainly want the other direction to keep them
in sync too.

regards, tom lane