pgsql: Improve some error messages with invalid indexes for REINDEX CON

Started by Michael Paquierover 2 years ago1 messagescomitters

michael@paquier.xyz

over 2 years ago

Improve some error messages with invalid indexes for REINDEX CONCURRENTLY

An invalid index is skipped when doing REINDEX CONCURRENTLY at table
level, with INDEX_CORRUPTED used as errcode. This is confusing,
because an invalid index could exist after an interruption. The errcode
is switched to OBJECT_NOT_IN_PREREQUISITE_STATE instead, as per a
suggestion from Andres Freund.

While on it, the error messages are reworded, and a hint is added,
telling how to rebuild an invalid index in this case. This has been
suggested by Noah Misch.

Discussion: /messages/by-id/20231118230958.4fm3fhk4ypshxopa@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d43bd090a8fee81fe88eb1e9e15e30d30ee130ed

Modified Files
--------------
src/backend/commands/indexcmds.c | 14 ++++++++------
src/test/regress/expected/create_index.out | 3 ++-
2 files changed, 10 insertions(+), 7 deletions(-)