pgsql: Refactor ATExecAddColumn() to use BuildDescForRelation()

Started by Peter Eisentrautover 2 years ago1 messagescomitters

peter_e@gmx.net

over 2 years ago

Refactor ATExecAddColumn() to use BuildDescForRelation()

BuildDescForRelation() has all the knowledge for converting a
ColumnDef into pg_attribute/tuple descriptor. ATExecAddColumn() can
make use of that, instead of duplicating all that logic. We just pass
a one-element list of ColumnDef and we get back exactly the data
structure we need. Note that we don't even need to touch
BuildDescForRelation() to make this work.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: /messages/by-id/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a1604237a6ffee70b171bacd5f36b0e380afd33a

Modified Files
--------------
src/backend/commands/tablecmds.c | 89 ++++++++++------------------------------
1 file changed, 22 insertions(+), 67 deletions(-)