pgsql: Generate syscache info from catalog files

Peter Eisentraut <peter@eisentraut.org> writes:

Generate syscache info from catalog files

Per guaibasaurus[1]https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&amp;dt=2024-01-23%2012%3A20%3A03, this commit broke "make dist":

...
rm -rf tmp_install/ portlock/
rm -f config.cache config.log config.status GNUmakefile
make[1]https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&amp;dt=2024-01-23%2012%3A20%3A03: Leaving directory '/home/pgsql/buildfarm/buildroot/HEAD/pgsql.build/postgresql-17devel'
/bin/tar chf postgresql-17devel.tar postgresql-17devel
/bin/tar: postgresql-17devel/src/include/catalog/syscache_ids.h: File removed before we read it
/bin/tar: postgresql-17devel/src/include/catalog/syscache_info.h: File removed before we read it
make: *** [GNUmakefile:94: postgresql-17devel.tar] Error 1
make: *** Deleting file 'postgresql-17devel.tar'

I'm not sure why --- the makefile changes treat these new files
exactly like other generated files. It doesn't repro here,
either, which is odd. It looks like a timing problem, but how
could there be one?

regards, tom lane

[1]: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&amp;dt=2024-01-23%2012%3A20%3A03

I wrote:

Peter Eisentraut <peter@eisentraut.org> writes:

Generate syscache info from catalog files

Per guaibasaurus[1], this commit broke "make dist":
...
I'm not sure why --- the makefile changes treat these new files
exactly like other generated files. It doesn't repro here,
either, which is odd. It looks like a timing problem, but how
could there be one?

Even odder: I did a test tarball build, and that worked too.
That runs on the very same VM as guaibasaurus, so what the heck?

regards, tom lane

On 23.01.24 15:08, Tom Lane wrote:

Peter Eisentraut <peter@eisentraut.org> writes:

Generate syscache info from catalog files

Per guaibasaurus[1], this commit broke "make dist":

...
rm -rf tmp_install/ portlock/
rm -f config.cache config.log config.status GNUmakefile
make[1]: Leaving directory '/home/pgsql/buildfarm/buildroot/HEAD/pgsql.build/postgresql-17devel'
/bin/tar chf postgresql-17devel.tar postgresql-17devel
/bin/tar: postgresql-17devel/src/include/catalog/syscache_ids.h: File removed before we read it
/bin/tar: postgresql-17devel/src/include/catalog/syscache_info.h: File removed before we read it
make: *** [GNUmakefile:94: postgresql-17devel.tar] Error 1
make: *** Deleting file 'postgresql-17devel.tar'

I'm not sure why --- the makefile changes treat these new files
exactly like other generated files. It doesn't repro here,
either, which is odd. It looks like a timing problem, but how
could there be one?

I have found that the files are not listed in the clean target in
src/include/Makefile. That might explain it, but it's gotta be fixed
anyway. I'll go ahead with that.

Peter Eisentraut <peter@eisentraut.org> writes:

On 23.01.24 15:08, Tom Lane wrote:

Per guaibasaurus[1], this commit broke "make dist":
I'm not sure why --- the makefile changes treat these new files
exactly like other generated files. It doesn't repro here,
either, which is odd. It looks like a timing problem, but how
could there be one?

I have found that the files are not listed in the clean target in
src/include/Makefile. That might explain it, but it's gotta be fixed
anyway. I'll go ahead with that.

Looks like that made guaibasaurus happy, but I'm still mystified
as to what was wrong and why it didn't repro elsewhere.

regards, tom lane

Hi,

I have found that the files are not listed in the clean target in
src/include/Makefile. That might explain it, but it's gotta be fixed
anyway. I'll go ahead with that.

Looks like that made guaibasaurus happy, but I'm still mystified
as to what was wrong and why it didn't repro elsewhere.

I noticed that catalog/syscache_ids.h is not installed when using
Meson. This breaks 3rd party extensions like this:

```
In file included from
/Users/eax/projects/c/timescaledb/tsl/test/src/compression_unit_test.c:19:
/Users/eax/pginstall/include/postgresql/server/utils/syscache.h:23:10:
fatal error: 'catalog/syscache_ids.h' file not found
#include "catalog/syscache_ids.h"
^~~~~~~~~~~~~~~~~~~~~~~~
```

It seems to me that include/catalog/meson.build should be modified,
however syscache_info.h *is* installed and I don't see why it would be
processed differently from syscache_ids.h.

There is no such problem with Autotools, it looks like 6eb6086faa38
did the trick.

--
Best regards,
Aleksander Alekseev

On 05.02.24 13:48, Aleksander Alekseev wrote:

Hi,

I have found that the files are not listed in the clean target in
src/include/Makefile. That might explain it, but it's gotta be fixed
anyway. I'll go ahead with that.

Looks like that made guaibasaurus happy, but I'm still mystified
as to what was wrong and why it didn't repro elsewhere.

I noticed that catalog/syscache_ids.h is not installed when using
Meson. This breaks 3rd party extensions like this:

```
In file included from
/Users/eax/projects/c/timescaledb/tsl/test/src/compression_unit_test.c:19:
/Users/eax/pginstall/include/postgresql/server/utils/syscache.h:23:10:
fatal error: 'catalog/syscache_ids.h' file not found
#include "catalog/syscache_ids.h"
^~~~~~~~~~~~~~~~~~~~~~~~
```

It seems to me that include/catalog/meson.build should be modified,
however syscache_info.h *is* installed and I don't see why it would be
processed differently from syscache_ids.h.

The code had this backward accidentally: syscache_ids.h should be
installed, but syscache_info.h not. I have fixed this. Thanks.