pgsql: Add lookup table for replication slot conflict reasons

Started by Michael Paquierover 2 years ago1 messagescomitters
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Add lookup table for replication slot conflict reasons

This commit switches the handling of the conflict cause strings for
replication slots to use a table rather than being explicitly listed,
using a C99-designated initializer syntax for the array elements. This
makes the whole more readable while easing future maintenance with less
areas to update when adding a new conflict reason.

This is similar to 74a730631065, but the scale of the change is smaller
as there are less conflict causes than LWLock builtin tranche names.

Author: Bharath Rupireddy
Reviewed-by: Jelte Fennema-Nio
Discussion: /messages/by-id/CALj2ACUxSLA91QGFrJsWNKs58KXb1C03mbuwKmzqqmoAKLwJaw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/943f7ae1c8693cf3ea59d103aaf9590ea062fb9c

Modified Files
--------------
src/backend/replication/slot.c | 45 ++++++++++++++++++++++++++-----------
src/backend/replication/slotfuncs.c | 24 +++++---------------
src/include/replication/slot.h | 13 +++++------
3 files changed, 43 insertions(+), 39 deletions(-)