pgsql: Mop-up for AIX-ectomy: remove now-dead test code.

Started by Tom Laneover 2 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Mop-up for AIX-ectomy: remove now-dead test code.

Commit 0b16bb877 removed the test query added by commit 79b716cfb,
but not the C-language support function used by that query. I don't
see any plausible reason why we'd need that function again, so throw
it overboard too.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f0827b443e6014a9d9fdcdd099603576154a3733

Modified Files
--------------
src/test/regress/expected/test_setup.out | 4 ----
src/test/regress/regress.c | 41 --------------------------------
src/test/regress/sql/test_setup.sql | 5 ----
3 files changed, 50 deletions(-)

#2Michael Paquier
michael@paquier.xyz
In reply to: Tom Lane (#1)
Re: pgsql: Mop-up for AIX-ectomy: remove now-dead test code.

On Wed, Feb 28, 2024 at 07:34:25PM +0000, Tom Lane wrote:

Mop-up for AIX-ectomy: remove now-dead test code.

Commit 0b16bb877 removed the test query added by commit 79b716cfb,
but not the C-language support function used by that query. I don't
see any plausible reason why we'd need that function again, so throw
it overboard too.

crake is complaining in some upgrade paths:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2024-02-28%2021%3A27%3A04

Some adjustments in AdjustUpgrade::adjust_new_dumpfile should do it, I
suppose.
--
Michael

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#2)
Re: pgsql: Mop-up for AIX-ectomy: remove now-dead test code.

Michael Paquier <michael@paquier.xyz> writes:

crake is complaining in some upgrade paths:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&amp;dt=2024-02-28%2021%3A27%3A04

Yeah, I'm on it...

regards, tom lane