pgsql: Code review for 6190d828cd2

Started by Amit Langoteover 2 years ago1 messagescomitters

Langote_Amit_f8@lab.ntt.co.jp

over 2 years ago

Code review for 6190d828cd2

* Fix the comment of init_dummy_sjinfo() to remove references to
non-existing parameters 'rel1' and 'rel2'.

* Adjust consider_new_or_clause() to call init_dummy_sjinfo() to make
up a SpecialJoinInfo for inner joins like other code sites that
were adjusted in 6190d828cd2 to do so.

Author: Richard Guo <guofenglinux@gmail.com>
Reported-by: Richard Guo <guofenglinux@gmail.com>
Discussion: /messages/by-id/CAExHW5tHqEf3ASVqvFFcghYGPfpy7o3xnvhHwBGbJFMRH8KjNw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0f7863afef67e462574fe5af6317e26a2f2d47fb

Modified Files
--------------
src/backend/optimizer/path/joinrels.c | 5 +++--
src/backend/optimizer/util/orclauses.c | 23 +++++------------------
2 files changed, 8 insertions(+), 20 deletions(-)