make everything target

Started by Andrew Dunstanabout 16 years ago12 messageshackers
Jump to latest
#1Andrew Dunstan
andrew@dunslane.net

I'd like to have an "everything" target that would build "all + html +
contrib".

And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.

Thoughts?

cheers

andrew

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Andrew Dunstan (#1)
Re: make everything target

On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:

I'd like to have an "everything" target that would build "all + html +
contrib".

+10

And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.

+100

#3David Fetter
david@fetter.org
In reply to: Andrew Dunstan (#1)
Re: make everything target

On Wed, Jan 27, 2010 at 10:41:16AM -0500, Andrew Dunstan wrote:

I'd like to have an "everything" target that would build "all + html
+ contrib".

And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.

Thoughts?

+1 on both :)

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#2)
Re: make everything target

Peter Eisentraut <peter_e@gmx.net> writes:

On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:

I'd like to have an "everything" target that would build "all + html +
contrib".

+10

And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.

+100

These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?

I assume we don't want to mess with the default behavior (I don't
want to, anyway).

regards, tom lane

#5David E. Wheeler
david@kineticode.com
In reply to: Tom Lane (#4)
Re: make everything target

On Jan 27, 2010, at 2:38 PM, Tom Lane wrote:

These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?

Oooh, more bike-shedding.

make theworld
make toutlemonde
make myday
make lovenotwar

Best,

David

#6Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#4)
Re: make everything target

Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:

I'd like to have an "everything" target that would build "all + html +
contrib".

+10

And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.

+100

These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?

I'm not invested in the name. Suggestions welcome.

I assume we don't want to mess with the default behavior (I don't
want to, anyway).

Me either, although it's a bit of a pity history has stuck us with the
default behaviour.

cheers

andrew

#7Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: David E. Wheeler (#5)
Re: make everything target

David E. Wheeler wrote:

On Jan 27, 2010, at 2:38 PM, Tom Lane wrote:

These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?

Oooh, more bike-shedding.

make theworld
make toutlemonde

"make world" sounds reasonable and I've remember seeing it elsewhere.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#8Andrew Dunstan
andrew@dunslane.net
In reply to: Alvaro Herrera (#7)
Re: make everything target

Alvaro Herrera wrote:

"make world" sounds reasonable and I've remember seeing it elsewhere.

Here's a simple patch. Comments?

cheers

andrew

Attachments:

pgmakefile.patchtext/x-patch; name=pgmakefile.patchDownload+20-0
#9Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Andrew Dunstan (#8)
Re: make everything target

Andrew Dunstan wrote:

Alvaro Herrera wrote:

"make world" sounds reasonable and I've remember seeing it elsewhere.

Here's a simple patch. Comments?

Should the new targets be added to Makefile too?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#10Andrew Dunstan
andrew@dunslane.net
In reply to: Alvaro Herrera (#9)
Re: make everything target

Alvaro Herrera wrote:

Andrew Dunstan wrote:

Alvaro Herrera wrote:

"make world" sounds reasonable and I've remember seeing it elsewhere.

Here's a simple patch. Comments?

Should the new targets be added to Makefile too?

Sure, good idea.

cheers

andrew

#11Andrew Dunstan
andrew@dunslane.net
In reply to: Andrew Dunstan (#10)
Re: make everything target

I wrote:

Alvaro Herrera wrote:

Andrew Dunstan wrote:

Alvaro Herrera wrote:

"make world" sounds reasonable and I've remember seeing it elsewhere.

Here's a simple patch. Comments?

Should the new targets be added to Makefile too?

Sure, good idea.

One more thing: do we want the new targets "world" and "install-world"
documented, or just left for developers?

cheers

andrew

#12Peter Eisentraut
peter_e@gmx.net
In reply to: Andrew Dunstan (#11)
Re: make everything target

On tor, 2010-01-28 at 16:21 -0500, Andrew Dunstan wrote:

One more thing: do we want the new targets "world" and
"install-world"
documented, or just left for developers?

Document them. How else would new developers learn about them?