make everything target
I'd like to have an "everything" target that would build "all + html +
contrib".
And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.
Thoughts?
cheers
andrew
On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:
I'd like to have an "everything" target that would build "all + html +
contrib".
+10
And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.
+100
On Wed, Jan 27, 2010 at 10:41:16AM -0500, Andrew Dunstan wrote:
I'd like to have an "everything" target that would build "all + html
+ contrib".And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.Thoughts?
+1 on both :)
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Peter Eisentraut <peter_e@gmx.net> writes:
On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:
I'd like to have an "everything" target that would build "all + html +
contrib".
+10
And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.
+100
These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?
I assume we don't want to mess with the default behavior (I don't
want to, anyway).
regards, tom lane
On Jan 27, 2010, at 2:38 PM, Tom Lane wrote:
These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?
Oooh, more bike-shedding.
make theworld
make toutlemonde
make myday
make lovenotwar
Best,
David
Tom Lane wrote:
Peter Eisentraut <peter_e@gmx.net> writes:
On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:
I'd like to have an "everything" target that would build "all + html +
contrib".+10
And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.+100
These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?
I'm not invested in the name. Suggestions welcome.
I assume we don't want to mess with the default behavior (I don't
want to, anyway).
Me either, although it's a bit of a pity history has stuck us with the
default behaviour.
cheers
andrew
David E. Wheeler wrote:
On Jan 27, 2010, at 2:38 PM, Tom Lane wrote:
These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?Oooh, more bike-shedding.
make theworld
make toutlemonde
"make world" sounds reasonable and I've remember seeing it elsewhere.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Alvaro Herrera wrote:
"make world" sounds reasonable and I've remember seeing it elsewhere.
Here's a simple patch. Comments?
cheers
andrew
Attachments:
pgmakefile.patchtext/x-patch; name=pgmakefile.patchDownload
Index: GNUmakefile.in
===================================================================
RCS file: /cvsroot/pgsql/GNUmakefile.in,v
retrieving revision 1.55
diff -c -r1.55 GNUmakefile.in
*** GNUmakefile.in 3 Nov 2009 21:28:10 -0000 1.55
--- GNUmakefile.in 28 Jan 2010 02:41:32 -0000
***************
*** 14,19 ****
--- 14,26 ----
$(MAKE) -C config all
@echo "All of PostgreSQL successfully made. Ready to install."
+ world:
+ $(MAKE) -C doc html
+ $(MAKE) -C src all
+ $(MAKE) -C config all
+ $(MAKE) -C contrib all
+ @echo "PostgreSQL, contrib and HTML documentation successfully made. Ready to install."
+
html man:
$(MAKE) -C doc $@
***************
*** 23,28 ****
--- 30,42 ----
$(MAKE) -C config $@
@echo "PostgreSQL installation complete."
+ install-world:
+ $(MAKE) -C doc install
+ $(MAKE) -C src install
+ $(MAKE) -C config install
+ $(MAKE) -C contrib install
+ @echo "PostgreSQL and contrib installation complete."
+
installdirs uninstall coverage:
$(MAKE) -C doc $@
$(MAKE) -C src $@
***************
*** 60,65 ****
--- 74,85 ----
check installcheck installcheck-parallel:
$(MAKE) -C src/test $@
+ installcheck-world:
+ $(MAKE) -C src/test installcheck
+ $(MAKE) -C src/pl installcheck
+ $(MAKE) -C interfaces/ecpg installcheck
+ $(MAKE) -C contrib installcheck
+
GNUmakefile: GNUmakefile.in $(top_builddir)/config.status
./config.status $@
Andrew Dunstan wrote:
Alvaro Herrera wrote:
"make world" sounds reasonable and I've remember seeing it elsewhere.
Here's a simple patch. Comments?
Should the new targets be added to Makefile too?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Alvaro Herrera wrote:
Andrew Dunstan wrote:
Alvaro Herrera wrote:
"make world" sounds reasonable and I've remember seeing it elsewhere.
Here's a simple patch. Comments?
Should the new targets be added to Makefile too?
Sure, good idea.
cheers
andrew
I wrote:
Alvaro Herrera wrote:
Andrew Dunstan wrote:
Alvaro Herrera wrote:
"make world" sounds reasonable and I've remember seeing it elsewhere.
Here's a simple patch. Comments?
Should the new targets be added to Makefile too?
Sure, good idea.
One more thing: do we want the new targets "world" and "install-world"
documented, or just left for developers?
cheers
andrew