Why doesn't smgr_redo truncate the VM fork too?

Started by Tom Lanealmost 16 years ago4 messages
#1Tom Lane
tgl@sss.pgh.pa.us

Seems inconsistent ...

regards, tom lane

#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Tom Lane (#1)
Re: Why doesn't smgr_redo truncate the VM fork too?

Tom Lane wrote:

Seems inconsistent ...

Indeed. Seems like an oversight.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Heikki Linnakangas (#2)
Re: Why doesn't smgr_redo truncate the VM fork too?

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:

Tom Lane wrote:

Seems inconsistent ...

Indeed. Seems like an oversight.

OK, will fix since I'm fooling with that code anyway.

regards, tom lane

#4Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Tom Lane (#3)
Re: Why doesn't smgr_redo truncate the VM fork too?

Tom Lane wrote:

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:

Tom Lane wrote:

Seems inconsistent ...

Indeed. Seems like an oversight.

OK, will fix since I'm fooling with that code anyway.

Thanks. While we're at it, the comment above visibilitymap_truncate()
has a copy-pasto in it (it claims the function is called visibilitymap_test)

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com