plperl message style on newly added messages

On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:

I notice that the new plperl error messages are somewhat out of line of
our usual style:

           ereport(ERROR,
                   (errcode(ERRCODE_INTERNAL_ERROR),
                       errmsg("while executing utf8fix"),
                       errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));

I think the errdetail field should really be errmsg, and the errdetail
should be errcontext.

There are several messages like this.

Should this be fixed?

Yes.

...Robert

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:

I notice that the new plperl error messages are somewhat out of line of
our usual style:

� � � � � �ereport(ERROR,
� � � � � � � � � �(errcode(ERRCODE_INTERNAL_ERROR),
� � � � � � � � � � � �errmsg("while executing utf8fix"),
� � � � � � � � � � � �errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));

I think the errdetail field should really be errmsg, and the errdetail
should be errcontext.

There are several messages like this.

Should this be fixed?

Yes.

Yes. Message style policing is exactly the kind of thing we should be
doing now. While you're at it, get rid of the
errcode(ERRCODE_INTERNAL_ERROR) if you can't find a better errcode ---
that's the default anyway.

regards, tom lane