pgsql: Allow meson builds to run test_pg_dump test in installcheck mode
Allow meson builds to run test_pg_dump test in installcheck mode.
This had been disabled because the test "doesn't delete its user".
It doesn't seem like a great idea for the meson tests to act
differently from the makefile tests, though, and the makefiles
had no such exception (which is how come only copperhead noticed
the problem just fixed in 534287403). In any case, the premise
is false since 936e3fa37, so let's remove the restriction.
Discussion: /messages/by-id/2857513.1713733688@sss.pgh.pa.us
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f663f4daf075b75268579c9a19d79de81b18c67b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Modified Files
--------------
src/test/modules/test_pg_dump/meson.build | 2 --
1 file changed, 2 deletions(-)
On Mon, Sep 23, 2024 at 11:40 PM Michael Paquier <michael@paquier.xyz> wrote:
Allow meson builds to run test_pg_dump test in installcheck mode.
This commit has Tom as the git author, and Michael as the git
committer. Was that intentional?
--
Peter Geoghegan
On Tue, Sep 24, 2024 at 09:42:59AM -0400, Peter Geoghegan wrote:
On Mon, Sep 23, 2024 at 11:40 PM Michael Paquier <michael@paquier.xyz> wrote:
Allow meson builds to run test_pg_dump test in installcheck mode.
This commit has Tom as the git author, and Michael as the git
committer. Was that intentional?
As a cherry-pick of an existing patch to an older branch, that's
intentional. I got remarks in the past that it was not right to do a
--reset-author in such cases.
--
Michael