pgsql: Make all ereport() calls within gram.y provide error locations.

Started by Tom Laneover 1 year ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Make all ereport() calls within gram.y provide error locations.

This patch responds to a comment that I (tgl) made in the
discussion leading up to 774171c4f, that really all errors
occurring during raw parsing should provide error cursors.
Syntax errors reported by Bison will have one, and most of
the handwritten ereport's in gram.y already provide one,
but there were a few stragglers.

(It is not claimed that this handles every failure reachable
during raw parsing --- out-of-memory is an obvious exception.
But this makes a good start on cases that are likely to occur.)

While we're at it, clean up the reported positions for errors
associated with LIMIT/OFFSET clauses. Previously we were
relying on applying exprLocation() to the contained expressions,
but that leads to slightly odd cursor placement, e.g.

regression=# (select * from foo limit 10) limit 10;
ERROR: multiple LIMIT clauses not allowed
LINE 1: (select * from foo limit 10) limit 10;
^

We can afford to keep a little more state in the transient
SelectLimit structs in order to make that better.

Jian He and Tom Lane (extracted from a larger patch by Jian,
with some additional work by me)

Discussion: /messages/by-id/CACJufxEmONE3P2En=jopZy1m=cCCUs65M4+1o52MW5og9oaUPA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2d8bff603c9ee7b284b85016fd1a8849ee36368d

Modified Files
--------------
src/backend/parser/gram.y | 74 +++++++++++++++++++++---------
src/test/regress/expected/create_table.out | 2 +
src/test/regress/expected/limit.out | 4 ++
src/test/regress/expected/sqljson.out | 4 ++
4 files changed, 62 insertions(+), 22 deletions(-)

#2Michael Paquier
michael@paquier.xyz
In reply to: Tom Lane (#1)
Re: pgsql: Make all ereport() calls within gram.y provide error locations.

Hi Tom,

On Thu, Oct 31, 2024 at 08:09:38PM +0000, Tom Lane wrote:

Make all ereport() calls within gram.y provide error locations.

This patch responds to a comment that I (tgl) made in the
discussion leading up to 774171c4f, that really all errors
occurring during raw parsing should provide error cursors.
Syntax errors reported by Bison will have one, and most of
the handwritten ereport's in gram.y already provide one,
but there were a few stragglers.

(It is not claimed that this handles every failure reachable
during raw parsing --- out-of-memory is an obvious exception.
But this makes a good start on cases that are likely to occur.)

While we're at it, clean up the reported positions for errors
associated with LIMIT/OFFSET clauses. Previously we were
relying on applying exprLocation() to the contained expressions,
but that leads to slightly odd cursor placement, e.g.

The tests of sepgsql need a refresh:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2024-10-31%2020%3A52%3A13

Thanks,
--
Michael

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#2)
Re: pgsql: Make all ereport() calls within gram.y provide error locations.

Michael Paquier <michael@paquier.xyz> writes:

The tests of sepgsql need a refresh:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&amp;dt=2024-10-31%2020%3A52%3A13

Yeah, I just noticed that. I'll deal with it tomorrow.

regards, tom lane