pgsql: Fix broken collate.icu.utf8 test in v12 branch.

Started by Tom Laneover 1 year ago2 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Fix broken collate.icu.utf8 test in v12 branch.

collate.icu.utf8.sql is not run by default before v13, and commits
9c4757491/46d9be5ef evidently didn't bother to test it, with
the completely predictable result that it was broken.
We didn't have enable_incremental_sort in v12, plus EXPLAIN makes
different table alias choices than later branches.

Per buildfarm member copperhead.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0ef9ac290ff3370f345fa08091c6586fecd8354f

Modified Files
--------------
src/test/regress/expected/collate.icu.utf8.out | 64 +++++++++++++-------------
src/test/regress/sql/collate.icu.utf8.sql | 2 -
2 files changed, 31 insertions(+), 35 deletions(-)

#2Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Tom Lane (#1)
Re: pgsql: Fix broken collate.icu.utf8 test in v12 branch.

Hi Tom,

On Mon, Nov 11, 2024 at 5:45 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

Fix broken collate.icu.utf8 test in v12 branch.

collate.icu.utf8.sql is not run by default before v13, and commits
9c4757491/46d9be5ef evidently didn't bother to test it, with
the completely predictable result that it was broken.
We didn't have enable_incremental_sort in v12, plus EXPLAIN makes
different table alias choices than later branches.

Sorry for the blunder, and thank you for taking care of it.

--
Thanks, Amit Langote