Conditional trigger missing from pg_dump

Started by Josh Berkusabout 16 years ago3 messageshackers
Jump to latest
#1Josh Berkus
josh@agliodbs.com

All,

It looks like pg_dump was never modified to include conditional
triggers. If you look in pg_dump.c, there's no provision to dump the
FOR UPDATE OF part of the trigger declaration.

This was discovered by Dave Olszewski while testing conditional triggers.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Josh Berkus (#1)
Re: Conditional trigger missing from pg_dump

Josh Berkus <josh@agliodbs.com> writes:

It looks like pg_dump was never modified to include conditional
triggers. If you look in pg_dump.c, there's no provision to dump the
FOR UPDATE OF part of the trigger declaration.

That proves nothing; it could be relying on server-side code to produce
the declaration.

This was discovered by Dave Olszewski while testing conditional triggers.

Please show a specific example of what you're worried about.

regards, tom lane

#3Josh Berkus
josh@agliodbs.com
In reply to: Tom Lane (#2)
Re: Conditional trigger missing from pg_dump

This was discovered by Dave Olszewski while testing conditional triggers.

Please show a specific example of what you're worried about.

I'll get you a reproduceable test case later today. In our testing, the
conditional part of the trigger was not being dumped.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com