pgsql: Change _mdfd_segpath() to return paths by value

Change _mdfd_segpath() to return paths by value

This basically mirrors the changes done in the predecessor commit. While there
isn't currently a need to get these paths in critical sections, it seems a
shame to unnecessarily allocate memory in these paths now that relpath()
doesn't allocate anymore.

Discussion: /messages/by-id/xeri5mla4b5syjd5a25nok5iez2kr3bm26j2qn4u7okzof2bmf@kwdh2vf7npra

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ecbff4378beecb0b1d12fc758538005a69821db1

Modified Files
--------------
src/backend/storage/smgr/md.c | 58 +++++++++++++++++++++++++---------------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 38 insertions(+), 21 deletions(-)