pgsql: Let caller of PageIsVerified() control ignore_checksum_failure

Started by Andres Freundover 1 year ago1 messagescomitters

andres@anarazel.de

over 1 year ago

Let caller of PageIsVerified() control ignore_checksum_failure

For AIO the completion of a read into shared buffers (i.e. verifying the page
including the checksum, updating the BufferDesc to reflect the IO) can happen
in a different backend than the backend that started the IO. As
ignore_checksum_failure can differ between backends, we need to allow the
caller of PageIsVerified() control whether to ignore checksum failures.

The commit leaves a gap in the PIV_* values, as an upcoming commit, which
depends on this commit, will add PIV_LOG_LOG, which better fits just after
PIV_LOG_WARNING.

Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: /messages/by-id/20250329212929.a6.nmisch@google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d445990adc419f435360f0dcd91c05c082f5fa3f

Modified Files
--------------
src/backend/catalog/storage.c | 7 +++++--
src/backend/storage/buffer/bufmgr.c | 6 +++++-
src/backend/storage/page/bufpage.c | 8 ++++++--
src/include/storage/bufpage.h | 1 +
4 files changed, 17 insertions(+), 5 deletions(-)