pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom

Started by Michael Paquierabout 1 year ago1 messagescomitters

michael@paquier.xyz

about 1 year ago

Revert "Add HINT for restartpoint race with KeepFileRestoredFromArchive()."

This reverts commit 8ad6c5dbbe5a, which was a commit specific to v14 and
older branches as the race condition between restartpoints and
KeepFileRestoredFromArchive() still existed.

1f95181b44c8 has worsened the situation on these two branches, causing
spurious failures in archive recovery (neither streaming nor archive
recovery) with concurrent restartpoints. The same logic as v15 and
newer versions will be applied in some follow-up commits to close this
problem, making this HINT not necessary anymore.

Reported-by: Arun Thirupathi
Discussion: /messages/by-id/20250306193013.36.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e77d9cd4f52ec40ec9edc823ee89612ddf300795

Modified Files
--------------
src/backend/access/transam/xlog.c | 5 +----
src/backend/storage/file/fd.c | 10 ++--------
2 files changed, 3 insertions(+), 12 deletions(-)