pgsql: Put enable_self_join_elimination into postgresql.conf.sample

On 6 Apr 2025, at 12:27, Alexander Korotkov <akorotkov@postgresql.org> wrote:

Put enable_self_join_elimination into postgresql.conf.sample

fc069a3a6319 implements Self-Join Elimination (SJE) and provides a new
GUC variable: enable_self_join_elimination. This commit adds
enable_self_join_elimination to the postgresql.conf.sample, as it was
forgotten in the original commit.

The GUC is marked GUC_NOT_IN_SAMPLE:

+       {"enable_self_join_elimination", PGC_USERSET, QUERY_TUNING_METHOD,
+           gettext_noop("Enable removal of unique self-joins."),
+           NULL,
+           GUC_EXPLAIN | GUC_NOT_IN_SAMPLE
+       },

..which is causing an error in the buildfarm:

# Failed test 'no parameters missing from guc_tables.c'
# at t/003_check_guc.pl line 89.
# got: '1'
# expected: '0'

# Failed test 'no parameters marked as NOT_IN_SAMPLE in postgresql.conf.sample'
# at t/003_check_guc.pl line 92.
# got: '1'
# expected: '0'
# Looks like you failed 2 tests of 3.

--
Daniel Gustafsson

On Sun, Apr 6, 2025 at 2:10 PM Daniel Gustafsson <daniel@yesql.se> wrote:

On 6 Apr 2025, at 12:27, Alexander Korotkov <akorotkov@postgresql.org> wrote:

Put enable_self_join_elimination into postgresql.conf.sample

fc069a3a6319 implements Self-Join Elimination (SJE) and provides a new
GUC variable: enable_self_join_elimination. This commit adds
enable_self_join_elimination to the postgresql.conf.sample, as it was
forgotten in the original commit.

The GUC is marked GUC_NOT_IN_SAMPLE:

+       {"enable_self_join_elimination", PGC_USERSET, QUERY_TUNING_METHOD,
+           gettext_noop("Enable removal of unique self-joins."),
+           NULL,
+           GUC_EXPLAIN | GUC_NOT_IN_SAMPLE
+       },

..which is causing an error in the buildfarm:

# Failed test 'no parameters missing from guc_tables.c'
# at t/003_check_guc.pl line 89.
# got: '1'
# expected: '0'

# Failed test 'no parameters marked as NOT_IN_SAMPLE in postgresql.conf.sample'
# at t/003_check_guc.pl line 92.
# got: '1'
# expected: '0'
# Looks like you failed 2 tests of 3.

Ooops, I'm going to revert this now.

------
Regards,
Alexander Korotkov
Supabase