pgsql: localbuf: Add Valgrind buffer access instrumentation

Started by Andres Freundover 1 year ago1 messagescomitters

andres@anarazel.de

over 1 year ago

localbuf: Add Valgrind buffer access instrumentation

This mirrors 1e0dfd166b3 (+ 46ef520b9566), for temporary table buffers. This
is mainly interesting right now because the AIO work currently triggers
spurious valgrind errors, and the fix for that is cleaner if temp buffers
behave the same as shared buffers.

This requires one change beyond the annotations themselves, namely to pin
local buffers while writing them out in FlushRelationBuffers().

Reviewed-by: Noah Misch <noah@leadboat.com>
Co-authored-by: Noah Misch <noah@leadboat.com>
Discussion: /messages/by-id/3pd4322mogfmdd5nln3zphdwhtmq3rzdldqjwb2sfqzcgs22lf@ok2gletdaoe6

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ab4241b9f4f73f2168bcaebc990f8b0a6b7bc81

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 13 +++++++++++++
src/backend/storage/buffer/localbuf.c | 25 +++++++++++++++++++++++++
2 files changed, 38 insertions(+)