pgsql: Rename argument in pg_get_process_memory_contexts().

Started by Daniel Gustafssonabout 1 year ago4 messagescomitters
Jump to latest
#1Daniel Gustafsson
daniel@yesql.se

Rename argument in pg_get_process_memory_contexts().

During development the third argument to pg_get_process_memory_contexts
was a retry count, but it was changed to a timeout instead. The param
name was accidentally left in pg_proc.dat though. Fix by renaming to
the correct parameter name.

Author: Fujii Masao <masao.fujii@oss.nttdata.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: /messages/by-id/3eb40b3e-45c7-426a-b7f8-81f7d05a9b53@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c57971034e69ca5705ac2be893a80ea82aca978b

Modified Files
--------------
src/include/catalog/pg_proc.dat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

#2David Rowley
dgrowleyml@gmail.com
In reply to: Daniel Gustafsson (#1)
Re: pgsql: Rename argument in pg_get_process_memory_contexts().

On Wed, 9 Apr 2025 at 09:22, Daniel Gustafsson
<dgustafsson@postgresql.org> wrote:

Rename argument in pg_get_process_memory_contexts().

src/include/catalog/pg_proc.dat | 2 +-

I think this should have done a catversion bump.

I suspect we'll get one soon enough, but you never know...

David

#3Michael Paquier
michael@paquier.xyz
In reply to: David Rowley (#2)
Re: pgsql: Rename argument in pg_get_process_memory_contexts().

On Wed, Apr 09, 2025 at 12:49:52PM +1200, David Rowley wrote:

On Wed, 9 Apr 2025 at 09:22, Daniel Gustafsson
<dgustafsson@postgresql.org> wrote:

Rename argument in pg_get_process_memory_contexts().

src/include/catalog/pg_proc.dat | 2 +-

I think this should have done a catversion bump.

Yes, the catversion should be bumped for an attribute rename in a
function.
--
Michael

#4Daniel Gustafsson
daniel@yesql.se
In reply to: Michael Paquier (#3)
Re: pgsql: Rename argument in pg_get_process_memory_contexts().

On 9 Apr 2025, at 06:02, Michael Paquier <michael@paquier.xyz> wrote:

On Wed, Apr 09, 2025 at 12:49:52PM +1200, David Rowley wrote:

On Wed, 9 Apr 2025 at 09:22, Daniel Gustafsson
<dgustafsson@postgresql.org> wrote:

Rename argument in pg_get_process_memory_contexts().

src/include/catalog/pg_proc.dat | 2 +-

I think this should have done a catversion bump.

Yes, the catversion should be bumped for an attribute rename in a
function.

Agreed, sorry about that, will fix.

--
Daniel Gustafsson