pgsql: Fix incorrect "return NULL" in BumpAllocLarge().

Started by Tom Laneabout 1 year ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Fix incorrect "return NULL" in BumpAllocLarge().

This must be "return MemoryContextAllocationFailure(context, size, flags)"
instead. The effect of this oversight is that if we got a malloc
failure right here, the code would act as though MCXT_ALLOC_NO_OOM
had been specified, whether it was or not. That would likely lead
to a null-pointer-dereference crash at the unsuspecting call site.

Noted while messing with a patch to improve our Valgrind leak
detection support. Back-patch to v17 where this code came in.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d4a7e4e179f946e12708f758d30a07f931fd5a84

Modified Files
--------------
src/backend/utils/mmgr/bump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)