pgsql: Expand virtual generated columns for ALTER COLUMN TYPE

Started by Richard Guoabout 1 year ago1 messagescomitters

rguo@postgresql.org

about 1 year ago

Expand virtual generated columns for ALTER COLUMN TYPE

For the subcommand ALTER COLUMN TYPE of the ALTER TABLE command, the
USING expression may reference virtual generated columns. These
columns must be expanded before the expression is fed through
expression_planner and the expression-execution machinery. Failing to
do so can result in incorrect rewrite decisions, and can also lead to
"ERROR: unexpected virtual generated column reference".

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: jian he <jian.universality@gmail.com>
Discussion: /messages/by-id/b5f96b24-ccac-47fd-9e20-14681b894f36@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5069fef1cfae271ca62e254b16dc831145bc5a4f

Modified Files
--------------
src/backend/commands/tablecmds.c | 3 +++
src/test/regress/expected/generated_virtual.out | 36 ++++++++++++++-----------
src/test/regress/sql/generated_virtual.sql | 10 ++++---
3 files changed, 30 insertions(+), 19 deletions(-)