Open Item: invalid declspec for PG_MODULE_MAGIC

Started by Takahiro Itagakiover 15 years ago2 messages

itagaki.takahiro@oss.ntt.co.jp

over 15 years ago

This open item is for replacing PGDLLIMPORT markers for PG_MODULE_MAGIC
and PG_FUNCTION_INFO_V1 to __declspec(dllexport) because they are always
expored by user modules rather than by the core codes.
http://archives.postgresql.org/message-id/20100329184705.A60E.52131E4D@oss.ntt.co.jp

The fix is simple, so I think we can include it to 9.0.
Arguable issues for the patch are:
* Are there better name than PGMODULEEXPORT? I like PGDLLEXPORT
because it is similar to PGDLLIMPORT, but it might be too similar.
* Should we backport the fix to previous releases?
I'd like to backport it because it should not break any existing
third party modules because they cannot be even built on Windows.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Tom Lane

tgl@sss.pgh.pa.us

over 15 years ago

In reply to: Takahiro Itagaki (#1)

Re: Open Item: invalid declspec for PG_MODULE_MAGIC

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:

* Should we backport the fix to previous releases?

Certainly not. It hasn't gotten through beta, and the risk of
breaking third-party modules is nonnegligible.

regards, tom lane