superfluous copydir() prototype in pg_upgrade.h

Started by Robert Haasalmost 16 years ago3 messageshackers
Jump to latest
#1Robert Haas
robertmhaas@gmail.com

While looking at Guillaume Lelarge's patch to add
CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
have a $SUBJECT.

Trivial patch attached.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachments:

remove-stray-copydir.patchapplication/octet-stream; name=remove-stray-copydir.patchDownload+0-1
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#1)
Re: superfluous copydir() prototype in pg_upgrade.h

Robert Haas <robertmhaas@gmail.com> writes:

While looking at Guillaume Lelarge's patch to add
CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
have a $SUBJECT.

Trivial patch attached.

The rmtree() declaration below it shouldn't be there either ...

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: superfluous copydir() prototype in pg_upgrade.h

Tom Lane wrote:

Robert Haas <robertmhaas@gmail.com> writes:

While looking at Guillaume Lelarge's patch to add
CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
have a $SUBJECT.

Trivial patch attached.

The rmtree() declaration below it shouldn't be there either ...

When pg_upgrade was not in /contrib, I was concerned about including
port.h, but at this point, I think it is fine. Both removed.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ None of us is going to be here forever. +