pgsql: instrumentation: Move ExecProcNodeInstr to allow inlining

Started by Andres Freund4 months ago1 messagescomitters

andres@anarazel.de

4 months ago

instrumentation: Move ExecProcNodeInstr to allow inlining

This moves the implementation of ExecProcNodeInstr, the ExecProcNode variant
that gets used when instrumentation is on, to be defined in instrument.c
instead of execProcNode.c, and marks functions it uses as inline.

This allows compilers to generate an optimized implementation, and shows a 4
to 12% reduction in instrumentation overhead for queries that move lots of
rows.

Author: Lukas Fittl <lukas@fittl.com>
Suggested-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: /messages/by-id/CAP53PkzdBK8VJ1fS4AZ481LgMN8f9mJiC39ZRHqkFUSYq6KWmg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/544000288ec8f7dc6a1e0285821adc47324ecd33

Modified Files
--------------
src/backend/executor/execProcnode.c | 20 --------------------
src/backend/executor/instrument.c | 37 +++++++++++++++++++++++++++++++------
src/include/executor/executor.h | 7 +++++++
3 files changed, 38 insertions(+), 26 deletions(-)