pgsql: Undo thinko in commit e78d1d6d4.

Started by Tom Lane13 days ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Undo thinko in commit e78d1d6d4.

In pursuit of removing a Valgrind-detected leak, I inserted
"pfree(pq_mq_handle);" into mq_putmessage's recursion-trouble-recovery
code path, failing to notice that shm_mq_detach would have pfree'd
that block just before (i.e., this particular code path did not leak).
So now that was a double pfree. We didn't notice because the
recursion scenario isn't exercised in our regression tests, but
Alexander Lakhin found it via code fuzzing.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: /messages/by-id/b8b40954-e155-41b3-9af8-ad4f261a1b64@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9d141466ff087230571e9c9dfd720deb94977253

Modified Files
--------------
src/backend/libpq/pqmq.c | 1 -
1 file changed, 1 deletion(-)