[PATCH] Use wait_classes.h in pg_prewarm
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t248652psql -h localhost -U postgresBuilt from patchset v1 (message #1), August 23, 2026 at 06:46 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t248652_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t248652_1 && git checkout t248652_1Patchset v1 (message #1) is on t248652_1
Hi Hackers,
While reading contrib/pg_prewarm/autoprewarm.c, I noticed that it includes
broader wait-event/statistics headers than it appears to need.
autoprewarm.c only uses PG_WAIT_EXTENSION for WaitLatch(). That macro is
defined in utils/wait_classes.h, so the attached patch includes that header
directly instead of pulling in pgstat.h and utils/wait_event.h.
This is my first patch to PostgreSQL, so please let me know if I missed
anything or if the patch should be handled differently.
Tests: meson test -C build pg_prewarm/regress pg_prewarm/001_basic
Regards,
Dongpo Liu
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
Hello,
I have first build postgres with make, run make check-world and make intstallcheck in pg_prewarm directory.
I have also successfully build postgres from source with meson, run 'meson test' and:
meson test -C build pg_prewarm/regress pg_prewarm/001_basic
1/2 postgresql:pg_prewarm / pg_prewarm/regress OK 0.37s 1 subtests passed
2/2 postgresql:pg_prewarm / pg_prewarm/001_basic OK 0.73s 11 subtests passed
Ok: 2
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0
LGTM.
I have set patch status to 'Ready for committer'.
Regards
Pierre Forstmann
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed
Hello,
Erratum: I send again the message after filling the Add Review form in the commitfest application.
I have first build postgres with make, run make check-world and make intstallcheck in pg_prewarm directory.
I have also successfully build postgres from source with meson, run 'meson test' and:
meson test -C build pg_prewarm/regress pg_prewarm/001_basic
1/2 postgresql:pg_prewarm / pg_prewarm/regress OK 0.37s 1 subtests passed
2/2 postgresql:pg_prewarm / pg_prewarm/001_basic OK 0.73s 11 subtests passed
Ok: 2
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0
LGTM.
I have set patch status to 'Ready for committer'.
Regards
Pierre Forstmann
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hello,
Erratum: I send again the message after filling all fields in the Add Review form.
LGTM.
I have set patch status to 'Ready for committer'.
Sorry for the noise: it is my first patch review.
Regards
Pierre Forstmann