JDBC: redundant String allocations removed
Hi all!
The enclosed patch removes redundant String allocations from the JDBC
driver. See attached submission report for more details.
William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com
Thanks, this tidy's some old "niggles" I've had since we merged the two
drivers some 2 years ago. I never got round to removing the redundant stuff.
I've managed to replace the dead disk, and have Linux installed again, so
hopefully this will be applied shortly.
Peter
--
Peter Mount
Enterprise Support Officer, Maidstone Borough Council
Email: petermount@maidstone.gov.uk
WWW: http://www.maidstone.gov.uk
All views expressed within this email are not the views of Maidstone Borough
Council
-----Original Message-----
From: William Webber [mailto:william@ferengi.live.com.au]
Sent: Friday, September 08, 2000 7:37 AM
To: pgsql-patches@postgresql.org
Subject: [PATCHES] JDBC: redundant String allocations removed
Hi all!
The enclosed patch removes redundant String allocations from the JDBC
driver. See attached submission report for more details.
William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com
Import Notes
Resolved by subject fallback
I can not seem to apply this to the current tree. Maybe Peter got some
of it in already. Peter?
---------------------------------------------------------------------------
#$ patch -p0 </bjm/55
patching file `postgresql/Connection.java'
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to postgresql/Connection.java.rej
patching file `postgresql/Driver.java'
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to postgresql/Driver.java.rej
patching file `postgresql/jdbc1/DatabaseMetaData.java'
Hunk #2 FAILED at 179.
Hunk #13 succeeded at 1644 with fuzz 1.
Hunk #14 succeeded at 1755 (offset 16 lines).
Hunk #16 FAILED at 1788.
Hunk #17 succeeded at 1867 (offset 16 lines).
Hunk #19 succeeded at 2099 (offset 16 lines).
Hunk #21 succeeded at 2522 (offset 16 lines).
2 out of 21 hunks FAILED -- saving rejects to postgresql/jdbc1/DatabaseMetaData.java.rej
patching file `postgresql/jdbc2/DatabaseMetaData.java'
Hunk #2 FAILED at 179.
Hunk #13 succeeded at 1644 with fuzz 1.
Hunk #14 succeeded at 1755 (offset 16 lines).
Hunk #16 FAILED at 1788.
Hunk #17 succeeded at 1867 (offset 16 lines).
Hunk #19 succeeded at 2099 (offset 16 lines).
Hunk #21 succeeded at 2522 (offset 16 lines).
2 out of 21 hunks FAILED -- saving rejects to postgresql/jdbc2/DatabaseMetaData.java.rej
Hi all!
The enclosed patch removes redundant String allocations from the JDBC
driver. See attached submission report for more details.William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com
[ Attachment, skipping... ]
[ Attachment, skipping... ]
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026On Tue, Sep 12, 2000 at 01:07:25AM -0400, Bruce Momjian wrote:
I can not seem to apply this to the current tree. Maybe Peter got some
of it in already. Peter?
In any case, these changes seem to have come in correctly at the
application of the ALTER TABLE <table> OWNER TO ... patch from Mark
Holloman (they weren't part of that patch, but came in when that patch
was applied), at least according to cvsweb, so all should be well.
William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com
Yes, that was a mistake. It still found your Connection.java and
Driver.java to be reversed, so they were skipped. Seems you are OK with
that? I really am no Java expert and I certainly appreciate your
patches.
On Tue, Sep 12, 2000 at 01:07:25AM -0400, Bruce Momjian wrote:
I can not seem to apply this to the current tree. Maybe Peter got some
of it in already. Peter?In any case, these changes seem to have come in correctly at the
application of the ALTER TABLE <table> OWNER TO ... patch from Mark
Holloman (they weren't part of that patch, but came in when that patch
was applied), at least according to cvsweb, so all should be well.William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Not yet, but it was about the next thing on my list.
--
Peter Mount
Enterprise Support Officer, Maidstone Borough Council
Email: petermount@maidstone.gov.uk
WWW: http://www.maidstone.gov.uk
All views expressed within this email are not the views of Maidstone Borough
Council
-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
Sent: Tuesday, September 12, 2000 6:07 AM
To: William Webber
Cc: pgsql-patches@postgresql.org
Subject: Re: [PATCHES] JDBC: redundant String allocations removed
I can not seem to apply this to the current tree. Maybe Peter got some
of it in already. Peter?
---------------------------------------------------------------------------
#$ patch -p0 </bjm/55
patching file `postgresql/Connection.java'
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to postgresql/Connection.java.rej
patching file `postgresql/Driver.java'
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to postgresql/Driver.java.rej
patching file `postgresql/jdbc1/DatabaseMetaData.java'
Hunk #2 FAILED at 179.
Hunk #13 succeeded at 1644 with fuzz 1.
Hunk #14 succeeded at 1755 (offset 16 lines).
Hunk #16 FAILED at 1788.
Hunk #17 succeeded at 1867 (offset 16 lines).
Hunk #19 succeeded at 2099 (offset 16 lines).
Hunk #21 succeeded at 2522 (offset 16 lines).
2 out of 21 hunks FAILED -- saving rejects to
postgresql/jdbc1/DatabaseMetaData.java.rej
patching file `postgresql/jdbc2/DatabaseMetaData.java'
Hunk #2 FAILED at 179.
Hunk #13 succeeded at 1644 with fuzz 1.
Hunk #14 succeeded at 1755 (offset 16 lines).
Hunk #16 FAILED at 1788.
Hunk #17 succeeded at 1867 (offset 16 lines).
Hunk #19 succeeded at 2099 (offset 16 lines).
Hunk #21 succeeded at 2522 (offset 16 lines).
2 out of 21 hunks FAILED -- saving rejects to
postgresql/jdbc2/DatabaseMetaData.java.rej
Hi all!
The enclosed patch removes redundant String allocations from the JDBC
driver. See attached submission report for more details.William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com
[ Attachment, skipping... ]
[ Attachment, skipping... ]
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Import Notes
Resolved by subject fallback
User has checked and it is all there. Thanks.
[ Charset ISO-8859-1 unsupported, converting... ]
Not yet, but it was about the next thing on my list.
--
Peter Mount
Enterprise Support Officer, Maidstone Borough Council
Email: petermount@maidstone.gov.uk
WWW: http://www.maidstone.gov.uk
All views expressed within this email are not the views of Maidstone Borough
Council-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
Sent: Tuesday, September 12, 2000 6:07 AM
To: William Webber
Cc: pgsql-patches@postgresql.org
Subject: Re: [PATCHES] JDBC: redundant String allocations removedI can not seem to apply this to the current tree. Maybe Peter got some
of it in already. Peter?---------------------------------------------------------------------------
#$ patch -p0 </bjm/55
patching file `postgresql/Connection.java'
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to postgresql/Connection.java.rej
patching file `postgresql/Driver.java'
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to postgresql/Driver.java.rej
patching file `postgresql/jdbc1/DatabaseMetaData.java'
Hunk #2 FAILED at 179.
Hunk #13 succeeded at 1644 with fuzz 1.
Hunk #14 succeeded at 1755 (offset 16 lines).
Hunk #16 FAILED at 1788.
Hunk #17 succeeded at 1867 (offset 16 lines).
Hunk #19 succeeded at 2099 (offset 16 lines).
Hunk #21 succeeded at 2522 (offset 16 lines).
2 out of 21 hunks FAILED -- saving rejects to
postgresql/jdbc1/DatabaseMetaData.java.rej
patching file `postgresql/jdbc2/DatabaseMetaData.java'
Hunk #2 FAILED at 179.
Hunk #13 succeeded at 1644 with fuzz 1.
Hunk #14 succeeded at 1755 (offset 16 lines).
Hunk #16 FAILED at 1788.
Hunk #17 succeeded at 1867 (offset 16 lines).
Hunk #19 succeeded at 2099 (offset 16 lines).
Hunk #21 succeeded at 2522 (offset 16 lines).
2 out of 21 hunks FAILED -- saving rejects to
postgresql/jdbc2/DatabaseMetaData.java.rejHi all!
The enclosed patch removes redundant String allocations from the JDBC
driver. See attached submission report for more details.William
--
William Webber william@peopleweb.net.au
Senior Programmer
PeopleWeb Australia http://www.peopleweb.com[ Attachment, skipping... ]
[ Attachment, skipping... ]
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026