RE: Patch for JDBC driver not returning correct # of re cords deleted
I've already got this one in ready to commit (it was way too late last night
:) )...
--
Peter Mount
Enterprise Support Officer, Maidstone Borough Council
Email: petermount@maidstone.gov.uk
WWW: http://www.maidstone.gov.uk
All views expressed within this email are not the views of Maidstone Borough
Council
-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
Sent: Tuesday, September 12, 2000 5:11 AM
To: Barry Lind
Cc: pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Patch for JDBC driver not returning correct # of
records deleted
I had a problem with the JDBC driver (in 7.0.2) always returning 1 as
the row count for deletes (whether the actual delete affected 0 or more
rows). In looking through the source this appears to be a simple one
line code fix.Change line 370 in src/interfaces/jdbc/org/postgresql/Connection.java
v1.1 from:
if(recv_status.startsWith("INSERT") ||
recv_status.startsWith("UPDATE")) {
to:
if(recv_status.startsWith("INSERT") ||
recv_status.startsWith("UPDATE") || recv_status.startsWith("DELETE")) {thanks,
--Barry
If I look at the code in the current CVS tree, I see a test only for
INSERT, and not INSERT and UPDATE. Can you supply a context diff that I
can apply? That would help me be sure I am changing the right lines.
Thanks.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Great, because I skipped that one.
[ Charset ISO-8859-1 unsupported, converting... ]
I've already got this one in ready to commit (it was way too late last night
:) )...--
Peter Mount
Enterprise Support Officer, Maidstone Borough Council
Email: petermount@maidstone.gov.uk
WWW: http://www.maidstone.gov.uk
All views expressed within this email are not the views of Maidstone Borough
Council-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
Sent: Tuesday, September 12, 2000 5:11 AM
To: Barry Lind
Cc: pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Patch for JDBC driver not returning correct # of
records deletedI had a problem with the JDBC driver (in 7.0.2) always returning 1 as
the row count for deletes (whether the actual delete affected 0 or more
rows). In looking through the source this appears to be a simple one
line code fix.Change line 370 in src/interfaces/jdbc/org/postgresql/Connection.java
v1.1 from:
if(recv_status.startsWith("INSERT") ||
recv_status.startsWith("UPDATE")) {
to:
if(recv_status.startsWith("INSERT") ||
recv_status.startsWith("UPDATE") || recv_status.startsWith("DELETE")) {thanks,
--BarryIf I look at the code in the current CVS tree, I see a test only for
INSERT, and not INSERT and UPDATE. Can you supply a context diff that I
can apply? That would help me be sure I am changing the right lines.
Thanks.-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026