Re: BeOS Patch

Started by Bruce Momjianover 25 years ago2 messagespatches
Jump to latest
#1Bruce Momjian
bruce@momjian.us

I just received this patch. Looks OK to me. Comments?

[ Charset ISO-8859-1 unsupported, converting... ]

Hi,

A small patch to have nice error messages on beos (I have some valid
negatives errors)

Thanks

cyril

===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/error/elog.c,v
retrieving revision 1.78
diff -c -r1.78 elog.c
*** elog.c	2001/01/21 00:59:26	1.78
--- elog.c	2001/01/22 19:09:26
***************
*** 146,152 ****
--- 146,156 ----
)
errorstr = strerror(errno);
else
+ #ifndef __BEOS__
errorstr = NULL;
+ #else
+ 		errorstr =strerror(errno);
+ #endif
/*
* Some strerror()s return an empty string for out-of-range errno.
* This is ANSI C spec compliant, but not exactly useful.
Index: exc.c
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/error/exc.c,v
retrieving revision 1.34
diff -c -r1.34 exc.c
*** exc.c	2001/01/21 00:59:26	1.34
--- exc.c	2001/01/22 19:09:26
***************
*** 122,128 ****
--- 122,132 ----
)
errorstr = strerror(errno);
else
+ #ifndef __BEOS__
errorstr = NULL;
+ #else
+ 		errorstr =strerror(errno);
+ #endif
/*
* Some strerror()s return an empty string for out-of-range errno.
* This is ANSI C spec compliant, but not exactly useful.
-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: Re: BeOS Patch

A small patch to have nice error messages on beos (I have some valid
negatives errors)

This looks like another reason to strip out the rangecheck on errno
completely. Since I was the one who put it in in the first place,
I will take responsibility for taking it out. Consider it history.

regards, tom lane