Cleanup of ODBC

Bruce Momjian <pgman@candle.pha.pa.us> writes:

I am working to clean up the comments in ODBC, and remove some blank
lines that make no sense being there. This will not affect the code in
any way. I should commit in a few hours.

Is it really appropriate to be doing this sort of work post-RC1?
I see no gain and a nontrivial risk that you will break something
without knowing it (and without providing adequate time to test it).

It's bad enough to be running pgindent at this late stage of the cycle,
but at least pgindent is automated and relatively unlikely to make
errors. Massive hand edits are another story.

In short: save it for 7.2.

regards, tom lane

Bruce Momjian <pgman@candle.pha.pa.us> writes:

I am working to clean up the comments in ODBC, and remove some blank
lines that make no sense being there. This will not affect the code in
any way. I should commit in a few hours.

Is it really appropriate to be doing this sort of work post-RC1?
I see no gain and a nontrivial risk that you will break something
without knowing it (and without providing adequate time to test it).

It's bad enough to be running pgindent at this late stage of the cycle,
but at least pgindent is automated and relatively unlikely to make
errors. Massive hand edits are another story.

In short: save it for 7.2.

OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian <pgman@candle.pha.pa.us> writes:

In short: save it for 7.2.

OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?

Not half as loud as they'll complain if we ship a broken ODBC in 7.1.

At this stage of the game we should only be applying bug fixes, and
only fairly critical ones at that ...

regards, tom lane

Bruce Momjian <pgman@candle.pha.pa.us> writes:

In short: save it for 7.2.

OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?

Not half as loud as they'll complain if we ship a broken ODBC in 7.1.

At this stage of the game we should only be applying bug fixes, and
only fairly critical ones at that ...

OK, I can hold them. Just don't let everyone jump on me when I apply
the ODBC comment cleanups when we branch 7.2.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

OK, here is the ODBC patch I am holding. I will run pgindent after I
apply it to 7.2 branch to properly wrap the comments.

Bruce Momjian <pgman@candle.pha.pa.us> writes:

I am working to clean up the comments in ODBC, and remove some blank
lines that make no sense being there. This will not affect the code in
any way. I should commit in a few hours.

Is it really appropriate to be doing this sort of work post-RC1?
I see no gain and a nontrivial risk that you will break something
without knowing it (and without providing adequate time to test it).

It's bad enough to be running pgindent at this late stage of the cycle,
but at least pgindent is automated and relatively unlikely to make
errors. Massive hand edits are another story.

In short: save it for 7.2.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

On Wed, 28 Mar 2001, Bruce Momjian wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

I am working to clean up the comments in ODBC, and remove some blank
lines that make no sense being there. This will not affect the code in
any way. I should commit in a few hours.

Is it really appropriate to be doing this sort of work post-RC1?
I see no gain and a nontrivial risk that you will break something
without knowing it (and without providing adequate time to test it).

It's bad enough to be running pgindent at this late stage of the cycle,
but at least pgindent is automated and relatively unlikely to make
errors. Massive hand edits are another story.

In short: save it for 7.2.

OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?

Who cares? Man, I'd hate for this project to ever get to the size of
Linux or FreeBSD ... we'd be spending so much time "cleaning" what doesn't
need to be cleaned that we'd get no work done *sigh*

OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?

Who cares? Man, I'd hate for this project to ever get to the size of
Linux or FreeBSD ... we'd be spending so much time "cleaning" what doesn't
need to be cleaned that we'd get no work done *sigh*

I am cleaning because I really can't do much else right now, and people
complain other times because they have open patches. Anyway, no ODBC
people have complained yet. I tried this earlier in beta and messed up
Hiroshi because he was working in this area.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian wrote:

OK, here is the ODBC patch I am holding. I will run pgindent after I
apply it to 7.2 branch to properly wrap the comments.

Hmm what a big patch !
I'm also holding a patch as I posted in pgsql-odbc.
Well when would you apply your patch ?

regards,
Hiroshi Inoue

Bruce Momjian wrote:

OK, here is the ODBC patch I am holding. I will run pgindent after I
apply it to 7.2 branch to properly wrap the comments.

Hmm what a big patch !
I'm also holding a patch as I posted in pgsql-odbc.
Well when would you apply your patch ?

Once we branch the tree for 7.2.

I just looked at your patch dated March 26 with subject "[ODBC] ODBC
changes about parameter handling." I don't see much duplicate change in
the two patches. If you want to apply yours first after 7.2 branches, I
will then apply mine and fix any rejects.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026